On Fri, 2009-04-03 at 16:07 -0400, Jeff Garzik wrote: > Mark Lord wrote: > > salimmu@xxxxxxxxxxxxxxxxxxxxxxx wrote: > >> Attach is a patch that adds translation of scsi WRITE_BUFFER to > >> ATA_DOWNLOAD_MICROCODE command.\ > > .. > > > > Do we really need or want this extra code in-kernel? > > > > This type of thing is already doable from user-space with SG_IO + ATA_16. > > Eg. hdparm --fwdownload > > If it can be done in userspace, I don't see much reason to add emulation > in libata-scsi.c... The only reason I might be able to see it isn't for firmware download, agreed, since nothing in the kernel would ever use it. If were were going to add some type of domain validation to the lines in SAS/SATA using write buffer echo tests, it might be more plausible, but that isn't the purpose of the patch. James -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
