Re: LibATA SCSI WRITE_BUFFER to ATA DOWNLOAD_MICROCODE patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2009-04-01 at 15:51 -0500, salimmu@xxxxxxxxxxxxxxxxxxxxxxx
wrote:
> +       mode = cdb[1] & 0x07; /* First 3 bits 0x07=00000111 */

SPC-3 defines this field as 5 bits; SPC-2 defined it as 4; it was only
the ancient SPC standard that defined it as three.

I think you need to up this to 5 bits otherwise you might get
interference from line verification attempts using the echo buffer
(which is defined as mode 10 ... and would translate to 2 if you just
believe the first 3 bits).

James


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux