Hello, Tejun Heo wrote: > Sagar Borikar wrote: >> Currently ahci driver assumes that the SATA controller is hooked up >> to the PCI. There are couple of devices like Synopsis Designware SATA >> controller with ahci sits on AHB interface and not on PCI. This patch >> is currently tied up to our platform and I have removed PCI dependent >> calls from the the driver. I still have to make it bus independent. >> Please review the patch and let me know if its fine. >> >> All comments are welcome. Also please note that this is not >> replacement of the existing ahci.c file I am going to create a new >> file for ahci_ahb.c But for review, I have compared against ahci.c >> Thanks > > Sagar, the amba changes look fine although I have no way of verifying > whether it works or not, but you just converted ahci from pci > dependent to amba dependent. The patch can't really be merged unless > we're willing to break all PCI ahci systems in favor of the amba one. > :-) Oops, you already mentioned this. Sorry about not reading before replying. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html