On Thursday 19 February 2009, FUJITA Tomonori wrote: > On Wed, 18 Feb 2009 21:59:49 +0100 > Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> wrote: > > > On Tuesday 17 February 2009, FUJITA Tomonori wrote: > > > Looks like that libata misuses dma_unmap_sg though I'm not familiar > > > with libata so I might completely misunderstand something. > > > > > > = > > > From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> > > > Subject: [PATCH] fix dma_unmap_sg misuse > > > > > > DMA-mapping.txt says: > > > > > > To unmap a scatterlist, just call: > > > > > > pci_unmap_sg(pdev, sglist, nents, direction); > > > > > > Again, make sure DMA activity has already finished. > > > > > > PLEASE NOTE: The 'nents' argument to the pci_unmap_sg call must be > > > the _same_ one you passed into the pci_map_sg call, > > > it should _NOT_ be the 'count' value _returned_ from the > > > pci_map_sg call. > > > > This is correct and other subsystems (SCSI, IDE) are compliant with it. > > > > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> > > > > Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> > > Thanks, > > I guess that the ide stack has the same problem (I guess that you > already knew that though). > > Looks like that the ide stack in linux-next has more serious problem > about handling dma_map_sg? > > In linux-next, the ide doesn't save the returned value of dma_map_sg > and assumes that dma_map_sg returns the same value to the 'nents' > argument of dma_map_sg? > > Again I'm not familiar with the ide stack at all so I might completely > misunderstand something. > > = > From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> > Date: Thu, 19 Feb 2009 21:51:17 +0900 > Subject: [PATCH] ide: save the returned value of dma_map_sg > > dma_map_sg could return a value different to 'nents' argument of > dma_map_sg so the ide stack needs to save it for the later usage > (e.g. for_each_sg). > > The ide stack also needs to save the original sg_nents value for > pci_unmap_sg. > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
