On Wed, 18 Feb 2009 17:12:35 -0500
Chuck Ebbert <cebbert@xxxxxxxxxx> wrote:
> On Tue, 17 Feb 2009 13:35:27 +0900
> FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> wrote:
>
> > From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
> > Subject: [PATCH] fix dma_unmap_sg misuse
> >
> > DMA-mapping.txt says:
> >
> > To unmap a scatterlist, just call:
> >
> > pci_unmap_sg(pdev, sglist, nents, direction);
> >
> > Again, make sure DMA activity has already finished.
> >
> > PLEASE NOTE: The 'nents' argument to the pci_unmap_sg call must be
> > the _same_ one you passed into the pci_map_sg call,
> > it should _NOT_ be the 'count' value _returned_ from the
> > pci_map_sg call.
> >
> > Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
> > ---
> > drivers/ata/libata-core.c | 4 ++--
> > include/linux/libata.h | 1 +
> > 2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> > index 9fbf059..5e324ce 100644
> > --- a/drivers/ata/libata-core.c
> > +++ b/drivers/ata/libata-core.c
> > @@ -4612,7 +4612,7 @@ void ata_sg_clean(struct ata_queued_cmd *qc)
> > VPRINTK("unmapping %u sg elements\n", qc->n_elem);
> >
> > if (qc->n_elem)
>
> if (qc->orig_n_elem)
> ?
Either is fine because when n_elem is not zero, qc->orig_n_elem is not
zero.
>
> > - dma_unmap_sg(ap->dev, sg, qc->n_elem, dir);
> > + dma_unmap_sg(ap->dev, sg, qc->orig_n_elem, dir);
> >
> > qc->flags &= ~ATA_QCFLAG_DMAMAP;
> > qc->sg = NULL;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
