Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello, I wrote:

   I meant IDE_TFLAG_IN_HOB_FEATURE, of course.

Once again blame the certain ioctl (you know which one)... :)
Moreover, the error register shoudn't be affeceted by the HOB bit, so this flag doesn't make sense.

Oh, horror... and I know that it wasn't completely ungrounded since both ATA/PI-6 adn -7 have words about reading the features register (depending on HOB). At least ATA/PI-8 got rid of this. Anyway, I think we can safely get rid of this flag and just return the same value in 'features' and 'hob_features'.

Although, after thinking a bit more, it doesn't seem worth the trouble -- so the rename should suffice...

MBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux