Re: [PATCH 3/3 v3] AT91: initialize Compact Flash on AT91SAM9263 cpu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hi Stanislaw,

> +       if (data->flags & AT91_CF_TRUE_IDE) {
> +               /* check if device is present */
> +               if (data->det_pin && at91_get_gpio_value(data->det_pin) != 0) {
> +                       printk(KERN_ERR "AT91 CF True IDE: no device detected\n");
> +                       return;
> +               }
> +               if (data->rst_pin) {
> +                       /* reset the card */
> +                       at91_set_gpio_output(data->rst_pin, 0);
> +                       /* wait as defined in ATA7 vol2 (rev 4a) figure 36 */
> +                       udelay(25);
> +                       at91_set_gpio_output(data->rst_pin, 1);
> +               }

Shouldn't this rather be done in the at91_ide driver?
I don't want to duplicate it in all the different at91sam9XX_devices.c files.

You could also define two separate "CF type" devices - one for CS4,
another for CS5.
That would allow for two independent "CF type" interfaces to be used
at the same time (see at91sam9260_devices.c in maxim.org.za patches).


Regards,
  Andrew Victor
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux