Re: [PATCH] libata-sff: fix 32-bit PIO regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello, I wrote:

Yes, looks nice, and works for me.  My only criticism would be,
minor issue unchanged by your patch, that actually "slop" isn't
unlikely enough to deserve an "unlikely" - slop of 1 or 3 is
unlikely, but slop of 2 is quite common.

Common on what types of ATAPI commands? I can hardly believe that they are
common on the block I/O...

When I checked (mounting and listing a CD), about 34% of
commands had slop 2.

Hm, that probably involved the raw block reads. I don't remember the raw sector length off-hand but it may well be just even, not divisble by 4.

   Oops, I read "listening" instead of "listing". :-/
But I thought that listing shouldn't involve anything other than block reads. OTOH, I'm not familiar enough with ISO9660... What commands are you seeing (if you have them dumped)?

But you're right, now I try copying
a large file, there's no slop involved in that at all.


Hugh

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux