Re: [PATCH 2/3] ide: add at91_ide driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Friday 06 February 2009 11:36:44 Sergei Shtylyov napisał(a):
> >>> +	host->ports[0]->extra_base = board->chipselect;
> >>>   
> >>>       
> >>    BTW, we have 2 fields in the struct hwif_s that fit this case better: 
> >> config_data and select_data. It's a bit stange that you've selected 
> >> extra_base...
> >>     
> > config_data is in use by IDE core,
> 
>    Hm, it shouldn't be. These fields are exclusively for drivers' use.
Right, it is just overwritten in ide_init_port_hw() and should be
setup by hw->config.

Stanislaw Gruszka

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux