On Sun, 1 Feb 2009, Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> > Subject: [PATCH] ide: include <asm/ide.h> only when needed > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> > --- > drivers/ide/ide-io-std.c | 7 +++++++ > drivers/ide/tx4938ide.c | 2 ++ > drivers/ide/tx4939ide.c | 2 ++ > include/linux/ide.h | 7 ------- > 4 files changed, 11 insertions(+), 7 deletions(-) > > Index: b/drivers/ide/ide-io-std.c > =================================================================== > --- a/drivers/ide/ide-io-std.c > +++ b/drivers/ide/ide-io-std.c > @@ -2,6 +2,13 @@ > #include <linux/kernel.h> > #include <linux/ide.h> > > +#if defined(CONFIG_ARM) || defined(CONFIG_M68K) || defined(CONFIG_MIPS) || \ > + defined(CONFIG_PARISC) || defined(CONFIG_PPC) || defined(CONFIG_SPARC) > +#include <asm/ide.h> > +#else > +#include <asm-generic/ide_iops.h> > +#endif > + > /* > * Conventional PIO operations for ATA devices > */ > Index: b/drivers/ide/tx4938ide.c > =================================================================== > --- a/drivers/ide/tx4938ide.c > +++ b/drivers/ide/tx4938ide.c > @@ -15,6 +15,8 @@ > #include <linux/init.h> > #include <linux/platform_device.h> > #include <linux/io.h> > + > +#include <asm/ide.h> Did you try checkpatch.pl? [...] > Index: b/include/linux/ide.h > =================================================================== > --- a/include/linux/ide.h > +++ b/include/linux/ide.h > @@ -193,13 +193,6 @@ static inline void ide_std_init_ports(hw > hw->io_ports.ctl_addr = ctl_addr; > } > > -#if defined(CONFIG_ARM) || defined(CONFIG_M68K) || defined(CONFIG_MIPS) || \ > - defined(CONFIG_PARISC) || defined(CONFIG_PPC) || defined(CONFIG_SPARC) > -#include <asm/ide.h> > -#else > -#include <asm-generic/ide_iops.h> > -#endif > - > #define MAX_HWIFS 10 > > /* As checkpatch.pl complains about any include of asm/*.h where the corresponding linux/*.h exists, this `fix' is incompatible with it. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html