Grant Grundler wrote:
On Fri, Jan 30, 2009 at 3:49 PM, Mark Lord <liml@xxxxxx> wrote:Update the logic in ata_qc_from_tag() to match that used in similar places elsewhere in libata. Signed-off-by: Mark Lord <mlord@xxxxxxxxx> --- old/drivers/ata/sata_mv.c 2009-01-30 18:23:22.000000000 -0500 +++ linux/drivers/ata/sata_mv.c 2009-01-30 18:26:55.000000000 -0500 @@ -1628,6 +1628,12 @@ if (pp->pp_flags & MV_PP_FLAG_NCQ_EN) return NULL; qc = ata_qc_from_tag(ap, ap->link.active_tag); + if (qc) { + if (qc->tf.flags & ATA_TFLAG_POLLING) + qc = NULL; + else if (!(qc->flags & ATA_QCFLAG_ACTIVE)) + qc = NULL; + } if (qc && (qc->tf.flags & ATA_TFLAG_POLLING)) qc = NULL;Mark, isn't the second test redudant now and can be removed?
.. Yes, and it has been. Keep reading. -ml -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
