On Friday 30 January 2009, Sergei Shtylyov wrote: > Kevin Hilman wrote: > > > Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> > > Acked-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> applied [ yay, this driver builds on x86 again :) ] > > diff --git a/drivers/ide/palm_bk3710.c b/drivers/ide/palm_bk3710.c > > index f38aac7..6196f76 100644 > > --- a/drivers/ide/palm_bk3710.c > > +++ b/drivers/ide/palm_bk3710.c > > @@ -347,7 +347,7 @@ static int __init palm_bk3710_probe(struct platform_device *pdev) > > struct clk *clk; > > struct resource *mem, *irq; > > void __iomem *base; > > - unsigned long rate; > > + unsigned long rate, mem_size; > > int i, rc; > > hw_regs_t hw, *hws[] = { &hw, NULL, NULL, NULL }; > > > > @@ -374,13 +374,19 @@ static int __init palm_bk3710_probe(struct platform_device *pdev) > > return -ENODEV; > > } > > > > - if (request_mem_region(mem->start, mem->end - mem->start + 1, > > + mem_size = mem->end - mem->start + 1; > > + if (request_mem_region(mem->start, mem_size, > > "palm_bk3710") == NULL) { > > No point in keeping *if* occupying 2 lines, I think... I fixed it while merging the patch. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html