Re: [PATCH] IDE: palm_bk3710: use ioremap instead of arch-specific IO_ADDRESS()

[Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>]

Hello.

Kevin Hilman wrote:

> Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>
>   

  Sorry, NAK.

> diff --git a/drivers/ide/palm_bk3710.c b/drivers/ide/palm_bk3710.c
> index f38aac7..be9c904 100644
> --- a/drivers/ide/palm_bk3710.c
> +++ b/drivers/ide/palm_bk3710.c
> @@ -380,7 +380,11 @@ static int __init palm_bk3710_probe(struct platform_device *pdev)
>  		return -EBUSY;
>  	}
>  
> -	base = IO_ADDRESS(mem->start);
> +	base = ioremap(mem->start, mem->end);
> +	if (!base) {
> +		printk(KERN_ERR "failed to map IO memory\n");
> +		return -ENOMEM;
>   

  Leaks requested memory region.

MBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html