Hi, > > - (void)ide_ack_intr(hwif); > + if (hwif->ack_intr(hwif)) > + hwif->ack_intr(hwif); > > Shouldn't that be: > > - (void)ide_ack_intr(hwif); > + if (hwif->ack_intr) > + hwif->ack_intr(hwif); Seconded. No point in ack'ing the int twice (not to mention the other side effects). Michael -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html