Re: [PATCH 1/4] ide: remove IDE_ARCH_INTR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> 
> -            (void)ide_ack_intr(hwif);
> +            if (hwif->ack_intr(hwif))
> +                hwif->ack_intr(hwif);
> 
> Shouldn't that be:
> 
> -            (void)ide_ack_intr(hwif);
> +            if (hwif->ack_intr)
> +                hwif->ack_intr(hwif);

Seconded. No point in ack'ing the int twice (not to mention the other side 
effects).

	Michael

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux