Re: [RFC][PATCH] at91_ide driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello, I wrote:

Well, we could add #ifdef with diffrent implementation of init_smc_mode(), set_8bit_mode(), etc...

  No, #ifdef'ery is certainly not an option.

Why?

It's totally ugly and unacceptable way of doing things. It seems also totally wrong to add support for totally incompatible SMC to this driver (especially with #ifdef's). Another driver should be written if CF support is required.

Other option is create some header files and implement and exporting these functions from processor specific code. This add files dependencies and spread
things across sources, FWIW.

   I don't think it's feasible as that SMC is just too different.

Besides, AT91RM9200 code turned out to already be registering a platform device called at91_cf -- driver for which I have located in drivers/pcmcia/, so apparently they're not interested in True IDE mode support (and have overgeneralized the name as well :-).

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux