On Saturday 24 January 2009, Russell King wrote: > On Sat, Jan 24, 2009 at 03:14:22PM +0100, Bartlomiej Zolnierkiewicz wrote: > > From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> > > Subject: [PATCH] icside: use struct ide_port_info also for PCB version 5 > > > > This fixes hwif->channel and drive->dn assignments. > > I really don't care about this driver anymore - people should > be using the PATA version instead. I really don't see major technical arguments for using libata version (especially after 2.6.29 IDE changes) but it's your call so if you want icside removed just send me a patch and I'll apply it (given that there are no complaints from users). [ No strong feelings here as it will allow me to better use my time and concentrate on working on code that people care about. ] > Nevertheless, this patch looks broken. > > > @@ -534,7 +538,7 @@ icside_register_v6(struct icside_state * > ^^^^^^^^^^^^^^^^^^ v6 function > > > d.dma_ops = NULL; > > } > > > > - ret = ide_host_register(host, NULL, hws); > > + ret = ide_host_register(host, &icside_v5_port_info, hws); > ^^^^^^^^^^^^^^^^^^^^^ v5 info Grrr.. and the other icside patch has v5->v6 mismatch. Thanks for noticing. I'll post corrected patches in few minutes. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
