> Since it is the second time this ->parent special case bited us in the *ss: > > pmac_ide_macio_attach(): > ... > hw.dev = &mdev->bus->pdev->dev; > hw.parent = &mdev->ofdev.dev; > ... > > I again wonder what is the reason for having different struct device-s used > for DBDMA and for device tree on MACIO PMAC controllers. Maybe there is no > real reason after all and we can use &mdev->ofdev.dev also for hwif->dev? Historically, dma_map_* wasn't supported on the macio devs, had to use the underlying pci dev. In fact, it might even still be the case. I need to have a look at it after LCA, though with our current DMA ops, it should be easy to fix. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html