Hello, I wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
Gah, what in the world is that SFF I/O code?
Index: b/drivers/ide/ide-io-sff.c =================================================================== --- /dev/null +++ b/drivers/ide/ide-io-sff.c @@ -0,0 +1,314 @@ + +#include <linux/kernel.h> +#include <linux/ide.h> + +/* + * Conventional PIO operations for ATA devices + */ + +static u8 ide_inb(unsigned long port) +{ + return (u8) inb(port); +} + +static void ide_outb(u8 val, unsigned long port) +{ + outb(val, port); +} + +/* + * MMIO operations, typically used for SATA controllers + */ + +static u8 ide_mm_inb(unsigned long port) +{ + return (u8) readb((void __iomem *) port); +} + +static void ide_mm_outb(u8 value, unsigned long port) +{ + writeb(value, (void __iomem *) port); +}
Ah, I see. Can we finally stop abusing the SFF name? Or are we bound to copy every mistake that libata has made? :-/
Please suggest a better name. :)
[ I'm also not happy with the naming but couldn't think of a better one. ]
Legacy perhaps?
As in ide-io-legacy.c. I can also suggest ide-io-std.c, ide-io-trad[itional].c...
MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
