Re: [PATCH 2/2] libata: New driver for OCTEON SOC Compact Flash interface (v6).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +	reg_cfg.s.orbit = 0;	/* Don't combine with previos region */

previous ...


> +static unsigned int octeon_cf_qc_issue(struct ata_queued_cmd *qc)
> +	case ATAPI_PROT_DMA:
> +		dev_err(ap->dev, "Error, ATAPI not supported\n");
> +		BUG();

Looks as if you should also have a check_atapi_dma function that always
returns non zero (or a mode filter for atapi -> pio)


Looks good to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux