Tejun Heo wrote: > Alan Cox wrote: >>> Can you please add comments to explain it? Also, it would be nice if >>> you do ap->ctl = ap->last_ctl and turn off ATA_TFLAG_DEVICE to avoid >>> loading them yet again. >> I don't think you can turn off ATA_TFLAG_DEVICE, you have no guarantee it >> won't be referred to again anywhere else in the stack - tf->flags isn't >> owned by the driver so its asking for trouble to do that. > > The original code copied tf to tmp_tf and turned it off there. New code > can do about the same thing. But then again, maybe it's just better to open code it at this point. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
