Re: sata_mv: trial fix for lost NCQ interrupts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Harri, as I reported on Redhat's Bugzilla (https://bugzilla.redhat.com/show_bug.cgi?id=462425), I think this is the fix as well...

Thanks for your port observation and Mark Lord's hard work on picking through the driver!!


----- Original Message ----- From: "Harri Olin" <harri.olin@xxxxxxxxx>
To: "Mark Lord" <liml@xxxxxx>
Cc: "IDE/ATA development list" <linux-ide@xxxxxxxxxxxxxxx>; "Brian Rademacher" <rad@xxxxxxxxxxxx>; "Eamonn Hamilton" <EAMONN.HAMILTON@xxxxxxxx>
Sent: Wednesday, January 14, 2009 4:18 PM
Subject: Re: sata_mv: trial fix for lost NCQ interrupts


Mark Lord wrote:
Harri Olin wrote:
..
I tried the patch and it works as well as it did without the patch. That is to say, timeouts still happen, every couple of minutes on moderate
..

Yup. On reflection, that patch has no effect, other than speeding things up.

However, I think I *have* found the actual bug this time.
Try this patch and report back again.

--- linux-2.6.28/drivers/ata/sata_mv.c 2009-01-13 15:57:11.000000000 -0500
+++ linux/drivers/ata/sata_mv.c    2009-01-14 16:56:38.000000000 -0500
@@ -883,7 +883,7 @@
        struct mv_host_priv *hpriv = ap->host->private_data;
        int hardport = mv_hardport_from_port(ap->port_no);
        void __iomem *hc_mmio = mv_hc_base_from_port(
-                    mv_host_base(ap->host), hardport);
+                    mv_host_base(ap->host), ap->port_no);
        u32 hc_irq_cause, ipending;

        /* clear EDMA event indicators, if any */

After first 55 minutes of testing, no timeouts yet, so I'm quite sure it works ok now (yay!). Without this patch, timeouts happened every couple minutes on similar load. I think I'll let it run for a day and report back tomorrow how things are by then.

Note that I didn't apply the previous patch as they don't apply on each other. If needed, I can test it separately after running this for a while.

Oh, and thanks for the hard work :)

--
Harri.

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux