-------- Original-Nachricht -------- > Datum: Mon, 12 Jan 2009 18:55:55 +0100 > Von: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> > An: "Gerhard Pircher" <gerhard_pircher@xxxxxxx> > CC: linux-ide@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxx, grant.likely@xxxxxxxxxxxx > Betreff: Re: [PATCH 5/5] ide: Force VIA IDE legacy interrupts for AmigaOne boards > > > checking if IDE_HFLAG_FORCE_LEGACY_IRQS should be set. > > Wouldn't it be better, if I clean this up now? (I have to resend my > > AmigaOne platform patches anyway). > > Replacement patch instead of incremental one is also fine with me -- given > that it can wait for 2.6.30. Yes, it can wait. Although I would like to know from the powerpc maintainer, if my platform patches could still go in 2.6.29, if I resend them in the next days? I guess it's too late, right? > > Okay, so the change shouldn't break IDE for Pegasos machines (I don't > > have a Pegasos for testing). > > Yes but there may be some other platforms (not necessarily powerpc ones) > that may be affected (i.e. they can depend indirectly on IRQ auto-probing > during IDE probe) so cleanup patch needs to spend some time in linux-next. I think the VIA libata driver simply checks the progif register, too. I guess you don't like the idea of a "#ifdef PPC32" or so around the ide_pci_is_in_compatibility_mode() check? Thanks! Gerhard -- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
