On Thursday 04 December 2008, Borislav Petkov wrote: > - cdrom_timer_expiry -> ide_cd_expiry > - remove expiry-arg to ide_issue_pc as it is redundant now > > There should be no functionality change resulting from this patch. Well, there is a minor change actually: ide_debug_log -> debug_log. > @@ -250,7 +251,38 @@ int ide_scsi_expiry(ide_drive_t *drive) > > return 0; /* we do not want the IDE subsystem to retry */ > } > -EXPORT_SYMBOL_GPL(ide_scsi_expiry); This seems to remove the symbol accidentally and although I've just applied patch doing scheduled ide-scsi removal it would be much better to take care of the core code's ide-scsi remnants in separate patch(es). > @@ -19,7 +19,6 @@ > /* > * typical timeout for packet command > */ > -#define ATAPI_WAIT_PC (60 * HZ) > #define ATAPI_WAIT_WRITE_BUSY (10 * HZ) The comment should be moved together with ATAPI_WAIT_PC define (or removed). The rest of the patch is fine. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
