Alexander Clausen writes: > Mikael Pettersson wrote: > > Mikael Pettersson writes: > > > > > > Are you absolutely certain both patches were applied and the driver rebuilt? > > > I'm asking because I would have expected to see > > > > > Yes, pretty sure. > > > > [...] sata_promise 0000:00:0d.0: restoring config space at offset 0x1 (...) > > > > > > but your kernel log does not contain anything like that. Both machines > > > I tested on today consistently included this message after the patch was > > > applied, but did not when the patch wasn't applied. > > Ok, that is strange. > > > > > > > I did note some temporary errors (that sata_promise recovered from) on > > > one machine after resuming from suspend to ram that did not occur when > > > using standby. I'll update the patch to include a controller reinit in > > > the ->resume op, which should hopefully fix that. > > > > Here's an updated suspend patch for sata_promise. It will now > > do a HW re-init of the controller and its ports on resume, > > which should help e.g. S2R when all state may have been lost. > > > > Depending on machine, suspend type (standby or mem), and disk > > I do get different results, some cases come up very cleanly > > while others have some transient failures; however in my tests > > libata EH always recovers. > > > > Only tested on 2nd gen controllers as my 1st gen is at another site. > > > > If this still doesn't work, try changing the #if 0 in pdc_pci_device_resume() > > to #if 1, that will make it issue a HW reset to all ATA engines before > > reinitialising them (shouldn't be needed, which is why it's disabled). > > Ok, I tried this patch (with and without the HW reset). Also, I disabled the NVidia driver, and > indeed, I did have APIC disabled (in the .config, no idea why, really), so I enabled it. > Same failure, still happens on second suspend, updated dmesgs attached. I tried these patches now on my K8T Neo FIS2R w/ PDC20378. I can do several standby suspends (S1) ok, but I can only do one mem suspend (S3): while it resumes w/o errors the machine hangs hard if I try a second S3 suspend. In that case there are no errors before the hang, so I can't tell if sata_promise is involved or not. Oh well, that machine has other issues as well (hangs during reboot if the CPU has been slowed down by cpufreq), so I'm considering that particular machine a lost cause wrt suspend. /Mikael -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
