On Tue, 25 Nov 2008 12:08:12 -0500 Jeff Garzik <jeff@xxxxxxxxxx> wrote: > Tejun Heo wrote: > > The DMA_IRQ bit in the bmdma status register is always set when IDEIRQ > > is asserted allowing spurious IRQ detection. Detect spurious IRQs and > > clear them. This protects ata_piix against nobody-cared which gets > > reported not so rarely. > > > > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx> > > --- > > drivers/ata/ata_piix.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 53 insertions(+), 1 deletion(-) > > It's tough to call this #upstream-fixes material, unfortunately... For > this late into -rc, I am very nervous about changing the ATA interrupt > path for millions of machines. I would like to go through the PIIX errata first. There are some rules about what registers may not be touched during a transfer on some of the devices and breaking them is *bad*. I don't think this is a problem but it makes me nervous. Now the DF draining on the other hand ;) Alan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html