Robert Hancock wrote: > Tejun Heo wrote: >> David Daney wrote: >>> ata: Remove inline attribute from ata_sff_host_intr() >>> >>> ata_sff_host_intr is a public function, it should not be declared >>> inline. >> >> Why not? >> > > Well, it's a bit unusual to have a non-static inline (an exported symbol > no less) in a C file.. how could any callers outside the file ever > actually inline it? Aside from that it seems a bit big for inlining.. The goal there is to inline ata_sff_host_intr() into ata_sff_interrupt() and then export a separate copy to other users as ata_sff_interrupt() is very hot. Looking at the disassembly, gcc is doing what it's told to do, so the inline actually is doing something useful there. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
