Alan Cox wrote: > On Fri, 21 Nov 2008 13:13:06 +0900 > Tejun Heo <tj@xxxxxxxxxx> wrote: > >> The DMA_IRQ bit in the bmdma status register is always set when IDEIRQ >> is asserted allowing spurious IRQ detection. Detect spurious IRQs and >> clear them. This protects ata_piix against nobody-cared which gets >> reported not so rarely. > > Various controllers have the ability to report the IRQ more reliably in > similar fashion, should this not be part of ata_sff_interrupt with an > optional ops->irq_pending call ? There are? That's a good news. Sure, if it's a common thing, we can definitely make it a callback. It actually goes together with ->sff_irq_clear pretty well. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html