On Wednesday 29 October 2008, Phil Sutter wrote:
> I copied the driver from the OpenWrt project to FreeWRT at Thu, 16 Nov
> 2006 and since then maintain it. As the current kernel for rb532 in
> FreeWRT is 2.6.19.1, intense testing has only been done basing on the
> local patches for the board support. After porting it to the linux-mips
> git tree, I could verify the functionality by mounting an ext2
> filesystem on the disk and reading/writing files in it.
Hmm, I thought that the old driver is an IDE driver not a stand-alone one
so I'm not much in favor of merging it as it is. However it still should
be useful in figuring out why pata_rb532_cf doesn't work correctly.
> +static irqreturn_t cf_irq_handler(int irq, void *dev_id)
> +{
> + /* While tasklet has not disabled irq, irq will be retried all the time
> + * because of ILEVEL matching GPIO pin status => deadlock.
> + * To avoid this, we change ILEVEL to 0.
> + */
> + struct cf_mips_dev *dev = dev_id;
> +
> + rb532_gpio_set_ilevel(0, dev->pin);
> + rb532_gpio_set_istat(0, dev->pin);
I cannot find the corresponding functionality in the new driver or arch code?
[ It seems that ->set_int_{level,status} methods from arch/mips/rb532/gpio.c
are not used anywhere in the kernel? ]
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
