Tejun Heo writes:
> Hello, Mikael.
>
> Mikael Pettersson wrote:
> > +static int pdc_pata_hardreset(struct ata_link *link, unsigned int *class,
> > + unsigned long deadline)
> > +{
> > + pdc_reset_port(link->ap);
> > + return 0;
> > +}
>
> You either need to return -EAGAIN here to ask for follow-up SRST or
> override softreset. I think pdc_reset_port() doesn't actually reset the
> ATA channel, right? In that case, the latter would be the correct thing
> to do.
(ponders..) ah yes, pata normally skips hardreset so this would
make it skip the needed softreset. pdc_reset_port() just reinits
the ATA engine, nothing else should be affected.
I'll update the patch to make pata override ->softreset instead.
Thanks.
/Mikael
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
