Hello. Tejun Heo wrote:
There were several places where only enabled devices should be iterated over but device enabledness wasn't checked. * IDENTIFY data 40 wire check in cable_is_40wire() * xfer_mode/ncq_enabled saving in ata_scsi_error() * DUBIOUS_XFER handling in ata_set_mode() While at it, reformat comment in cable_is_40wire(). Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
More nitpicking... :-)
Index: work/drivers/ata/libata-core.c =================================================================== --- work.orig/drivers/ata/libata-core.c +++ work/drivers/ata/libata-core.c @@ -4169,18 +4169,16 @@ static int cable_is_40wire(struct ata_po if (ap->cbl == ATA_CBL_PATA40_SHORT) return 0; /* If the controller doesn't know we scan - - - Note: We look for all 40 wire detects at this point. - Any 80 wire detect is taken to be 80 wire cable - because - - In many setups only the one drive (slave if present) - will give a valid detect - - If you have a non detect capable drive you don't - want it to colour the choice - */ + * + * - Note: We look for all 40 wire detects at this point. Any + * 80 wire detect is taken to be 80 wire cable because - In + * many setups only the one drive (slave if present) will + * give a valid detect - If you have a non detect capable + * drive you don't want it to colour the choice + */
The comment formatting now is worse than it was... I'd drop hyphen before "Note:" and align the bullets under this note (also doing s/If/if/).
MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
