On Fri, Oct 24, 2008 at 09:24:29AM +0200, Jens Axboe wrote: > On Fri, Oct 24 2008, Paul Mundt wrote: > > On Fri, Oct 24, 2008 at 09:13:29AM +0200, Jens Axboe wrote: > > > Darn, this smells like a train wreck. I'm assuming this fixes it? > > > > > Yes, that fixes it. > > OK, that's pretty bad. 2.6.28-rc1 will not work on any box using libata > with non-ncq disks. If you need me, I'll be at the bar. > At least you only missed -rc1 by a few hours, it was a good effort.. :-) > From e598055dde1951c47c8b3522616f6ebff0ed9847 Mon Sep 17 00:00:00 2001 > From: Jens Axboe <jens.axboe@xxxxxxxxxx> > Date: Fri, 24 Oct 2008 09:22:42 +0200 > Subject: [PATCH] libata: fix bug with non-ncq devices > > The recent commit 201f1b98822078c808b5e2d379a6ddbfc0a06ee1 to enable > support for block layer tagging in libata was broken for non-NCQ > devices. The block layer initializes the tag field to -1 to detect > invalid uses of a tag, and if the libata devices does NOT support > NCQ, we just used that field to index the internal command list. > So we need to check for -1 first and only use the tag field if > it's valid. > > Signed-off-by: Jens Axboe <jens.axboe@xxxxxxxxxx> Tested-by: Paul Mundt <lethal@xxxxxxxxxxxx> Thanks for the quick fix! Now I can go back to hacking on the stuff I was avoiding.. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
