On Tuesday 21 October 2008, Sergei Shtylyov wrote: > > + pr_err("%s: Error interrupt %#x (%s%s%s )\n", > > + hwif->name, ctl, > > + (ctl & TX4939IDE_INT_ADDRERR) ? > > + " Address-Error" : "", > > + (ctl & TX4939IDE_INT_DEVTIMING) ? > > + " DEV-Timing" : "", > > + (ctl & TX4939IDE_INT_BUSERR) ? > > Parens around & shouldn't be needed... While the above remark is certainly correct we usually leave such parens to ease the reading of the code and to match the other parts of the kernel... [ No need to change it again, just a minor note... ] -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html