On Wednesday 22 October 2008, Sergei Shtylyov wrote: > Arjan van de Ven wrote: > > >>>>Use the newly introduced pci_ioremap_bar() function in drivers/ide. > >>>>pci_ioremap_bar() just takes a pci device and a bar number, with > >>>>the goal of making it really hard to get wrong, while also having > >>>>a central place to stick sanity checks. > > >>>>Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> > > >>>Acked-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> > > >> No, I'm takign back my ACK. > >> Since the patch intends to address all drivers/ide/, it's clearly > >>no compolete -- siimage.c and scc_pata.c beg for the alike change (it > >>will even permit to kill 4 local variables in the latter driver). > > > like this ? > > Exactly. > > > From 3f88a6936f7802a5d4af6c54a1ef353d14ff1ab2 Mon Sep 17 00:00:00 2001 > > From: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> > > Date: Wed, 22 Oct 2008 13:21:07 -0700 > > Subject: [PATCH] ide: two more pci_ioremap_bar() conversions > > > based on suggestion from Sergei Shtylyov, there are two more places > > where using pci_ioremap_bar() makes sense. > > > Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> > > Acked-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> applied -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
