On Wed, 22 Oct 2008 21:40:37 +0400 Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> wrote: > Hello, I wrote: > > >> Use the newly introduced pci_ioremap_bar() function in drivers/ide. > >> pci_ioremap_bar() just takes a pci device and a bar number, with > >> the goal of making it really hard to get wrong, while also having > >> a central place to stick sanity checks. > > >> Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> > > > Acked-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> > > No, I'm takign back my ACK. > Since the patch intends to address all drivers/ide/, it's clearly > no compolete -- siimage.c and scc_pata.c beg for the alike change (it > will even permit to kill 4 local variables in the latter driver). > > MBR, Sergei I'll be happy to take a second pass, but "doesn't convert everyone" shouldn't really be a reason to do the first pass ;-) -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
