> > if (ata_is_atapi(qc->tf.protocol) && > > - !(qc->dev->flags & ATA_DFLAG_CDB_INTR)) > > + !(qc->dev->flags & ATA_DFLAG_CDB_INTR)) > > Ditto. Its lining up the bracketing but hey I'm not fussed, just twiddling where checkpatch warned and the like. > > - err_out: > > +err_out: > > Yes, I've wondered about these myself occasionally. Personally, I don't > insert a blank before those labels either and would be in favour of such > a change. But do we actually have a convention regarding this matter? CodingStyle chapter 7 which is of course overridable by Jeff ;) Alan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html