On Wed, Oct 15, 2008 at 09:40:42PM -0600, Alex Chiang wrote: > * Tejun Heo <tj@xxxxxxxxxx>: > > Alex Chiang wrote: > > > Shuts up gcc-3.4.5-glibc-2.3.6 when it complains of: > > > > > > drivers/ata/libata-scsi.c: In function `ata_scsi_scan_host': > > > drivers/ata/libata-scsi.c:3225: warning: 'dev' might be used > > > uninitialized in this function > > > > > > Signed-off-by: Alex Chiang <achiang@xxxxxx> > > > > Nacked-by: Tejun Heo <tj@xxxxxxxxxx> > > > > Some gcc versions complain about sata_via, others complain > > about something else. Some versions complain about some > > iterator usages while not complaining about others, but none of > > those complaints is actually wrong or dangerous. I don't think > > adding = NULL whenever some version of gcc complains is the > > right approach. > > Hm, ok. > > I guess we don't want to sprinkle these around all over the place > just to solve cosmetic issues, which makes sense, but is there > some other approach we could take instead? Any suggestions? Or > just live with it? We have an annotation for these kinds of warnings in the kernel. But we'll never get a warning-free compilation with all seven (sic) supported gcc release series. A warning-free compilation with gcc 4.3 is worth some efforts, but cluttering our code to fix bogus warnings with older gcc versions is not a good thing. > /ac cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html