On Saturday 11 October 2008, Elias Oltmanns wrote: > Fix a memory leak due to a missing blk_put_request() in > issue_park_cmd(). Additionally, we should plug the queue when enqueueing > the unpark request because there is no guarantee that the park timeout > has not expired by then. Even though the chance for that to happen is > very slim, the request might end up hanging in the queue until the next > I/O operation is queued up. While at it, clean up the code a little: > - make issue_park_cmd() a function of type void since nobody cares for > the return value anyway; > - use blk_start_queueing() instead of __blk_run_queue() since we don't > have to worry about recursion; > - remove a superfluous pointer deference in task_no_data_intr(). > > Signed-off-by: Elias Oltmanns <eo@xxxxxxxxxxxxxx> > --- > Feel free to merge with original patch if Linus hasn't pulled your tree > yet. done, thanks -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
