> If I remember rightly this check is necessary because phy_info can be > NULL in certain situations. Your patch will trip this to oops. What In which case it will already have crashed > your description needs to say is that we no longer need to check this > pointer for NULL because it was checked somewhere else in the stack ... > but I can't see where that is, where is it? We don't check: but if it was NULL we then fall straight through and dereference it unconditionally... so either its a wrong NULL check and the old code oopses (which a trawl says it doesn't) or the check is bogus. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
