On Friday, 3 of October 2008, Arjan van de Ven wrote: > On Fri, 3 Oct 2008 13:27:18 +0200 > "Rafael J. Wysocki" <rjw@xxxxxxx> wrote: > > > On Friday, 3 of October 2008, Andrew Morton wrote: > > > On Tue, 30 Sep 2008 00:10:37 +0200 "Rafael J. Wysocki" > > > <rjw@xxxxxxx> wrote: > > > > > > > Hibernation: Introduce new system state for the last phase of > > > > hibernation > > > > > > > > Replace unused SYSTEM_SUSPEND_DISK with a new system_state value > > > > SYSTEM_HIBERNATE_ENTER that can be used by device drivers to > > > > check if the system is in the last phase of hibernation. > > > > > > Violent objections. > > > > > > We just don't know what this change will do. It potentially affects > > > every code site in the kernel which looks at system_state. > > > > Do you mean anyone checking 'system_state != SOMETHING' ? Oh well. > > I think Andrew also means things looking for system_state > something > like > > arch/powerpc/platforms/cell/smp.c: if (system_state < SYSTEM_RUNNING && > arch/powerpc/kernel/smp.c: if (system_state < SYSTEM_RUNNING) > arch/powerpc/kernel/smp.c: if (system_state > SYSTEM_BOOTING) > drivers/xen/xenbus/xenbus_probe.c: if (system_state > SYSTEM_RUNNING) { These particular ones shouldn't be affected AFAICS. Anyway, I'm going to respin the patchset to take the Andrew's comment into account. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html