On Thu, Oct 02, 2008 at 09:22:31AM +0900, Tejun Heo wrote: > Greg KH wrote: > > On Mon, Sep 08, 2008 at 09:17:30PM +0200, Tejun Heo wrote: > >> Tejun Heo wrote: > >>> From 2.6.26, libata is defaulting to hardreset for various reasons one > >>> of them being unifying probing, hotplug and EH reset paths uniform. > >>> Previously, broken hardreset could go unnoticed as it wasn't used > >>> during probing but when something goes wrong or after hotplug the > >>> problem will surface and bite hard. > >>> > >>> OSDL bug 11195 reports that sata_nv generic flavor falls into this > >>> category. Hardreset itself succeeds but PHY stays offline after > >>> hardreset. I tried longer debounce timing but the result was the > >>> same. > >>> > >>> http://bugzilla.kernel.org/show_bug.cgi?id=11195 > >>> > >>> So, it seems we'll have to drop hardreset from the generic flavor. > >>> > >>> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx> > >>> Cc: Peer Chen <pchen@xxxxxxxxxx> > >> This one definitely should go into -stable too. The original patch is... > >> > >> http://article.gmane.org/gmane.linux.ide/34077/raw > > > > Now applied, thanks. > > Greg, can you please hold a bit before releasing this? This patch > accidentally disables hardreset for all flavors of nv controllers which > causes problems for ck804. A later patch to only apply it to generic > went in but it then broke nf2 flavor, so it seems generic and nf2 > require this workaround but ck804 doesn't like the workaround. I've > asked a reporter to test to apply the workaround only to generic and nf2 > and will forward the third patch as soon as it's confirmed. So, please > wait till the third one is ready. Ok, I've dropped: sata_nv-disable-hardreset-for-generic.patch from the 2.6.26-stable queue for now. If you get it all working, please resend all of the patches that you wish me to pick up for a -stable release (well send them to stable@xxxxxxxxxx, not me directly.) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
