George Spelvin wrote: > ATM I'm just recompiling the kernel from -rc6 to -rc7. > > It's in single-user mode so I can't ssh over the boot messages, but > they definitely included "64bit" from ahci_print_info(). Thanks for verifying. I would love to lift the 32 restriction from SB600 but it's been quite a rocky ride and I still can't tell what's the determining factor. :-( > Speaking of anci_print_info(), sould something like the following be a good > thing? > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index 2e1a7cb..18137d2 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -2464,22 +2464,22 @@ static void ahci_print_info(struct ata_host *host) > "%s\n" > , > > - cap & (1 << 31) ? "64bit " : "", > - cap & (1 << 30) ? "ncq " : "", > - cap & (1 << 29) ? "sntf " : "", > - cap & (1 << 28) ? "ilck " : "", > - cap & (1 << 27) ? "stag " : "", > - cap & (1 << 26) ? "pm " : "", > - cap & (1 << 25) ? "led " : "", > - > - cap & (1 << 24) ? "clo " : "", > - cap & (1 << 19) ? "nz " : "", > - cap & (1 << 18) ? "only " : "", > - cap & (1 << 17) ? "pmp " : "", > - cap & (1 << 15) ? "pio " : "", > - cap & (1 << 14) ? "slum " : "", > - cap & (1 << 13) ? "part " : "", > - cap & (1 << 6) ? "ems ": "" > + cap & HOST_CAP_64 ? "64bit " : "", > + cap & HOST_CAP_NCQ ? "ncq " : "", > + cap & HOST_CAP_SNTF ? "sntf " : "", > + cap & (1 << 28) ? "ilck " : "", > + cap & HOST_CAP_SSS ? "stag " : "", > + cap & HOST_CAP_ALPM ? "pm " : "", > + cap & (1 << 25) ? "led " : "", > + > + cap & HOST_CAP_CLO ? "clo " : "", > + cap & (1 << 19) ? "nz " : "", > + cap & (1 << 18) ? "only " : "", > + cap & HOST_CAP_PMP ? "pmp " : "", > + cap & (1 << 15) ? "pio " : "", > + cap & HOST_CAP_SSC ? "slum " : "", > + cap & (1 << 13) ? "part " : "", > + cap & HOST_CAP_EMS ? "ems ": "" Yeah, probably. While at it, can you just add constants for other bits too and send it as properly singed off patch? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
