Hello. Ralf Baechle wrote:
+{
[...]
+ pdev = platform_device_register_simple(DEV_NAME, -1, + swarm_ide_resource, ARRAY_SIZE(swarm_ide_resource));
If you have the resources as static array anyway, why not have the device in the static variable too and use platform_device_register()?
It saves a few lines of code.
And wastes few words of static data since platform_device_register_simple() will kmalloc() the resources and do a copy from these resources after which they are not needed -- so, it's worth making swarm_ide_resource[] __initdata at least. If you were using platform_device_register() with static platform device, no memory allocation would have happened, and no data would have been wasted.
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
