Hello.
Mark de Wever wrote:
After updating my kernel to 2.6.26 the output for the ide-tape drive
during booting is garbled eg
ide-tape: hdd <-> ht0: Seagate <98>ß8A51|1À<81>ܺ<98>ß STT20000A rev 8A51|1À<81>ܺ<98>ß
This patch fixes the problem by NULL terminating the strings.
Regards,
Mark de Wever
PS: please CC me since I'm not subscribed.
PPS: there are more problems with my tapestreamer in 2.6.26 but I'll
post a separate message for that.
Signed-off-by: Mark de Wever <koraq@xxxxxxxxx>
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 1bce84b..fd87b43 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -2354,6 +2354,10 @@ static void idetape_get_inquiry_results(ide_drive_t *drive)
ide_fixstring(product_id, 18, 0);
ide_fixstring(fw_rev, 6, 0);
+ fw_rev[4] = '\0';
+ vendor_id[8] = '\0';
+ product_id[16] = '\0';
+
printk(KERN_INFO "ide-tape: %s <-> %s: %s %s rev %s\n",
drive->name, tape->name, vendor_id, product_id, fw_rev);
This is not quite correct way to tackle this. More correct would be to
fix the format specifiers in this printk() to only print no more than N string
characters like this:
printk(KERN_INFO "ide-tape: %s <-> %s: %.8s %.16s rev %.4s\n",
drive->name, tape->name, vendor_id, product_id, fw_rev);
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
