On Mon, 08 Sep 2008 21:12:10 +0200 Tejun Heo <htejun@xxxxxxxxx> wrote: > Stephen Hemminger wrote: > > Not sure how you want to fix this: > > > > CHECK drivers/acpi/pci_irq.c > > drivers/ata/ahci.c:323:2: warning: Initializer entry defined twice > > drivers/ata/ahci.c:324:3: also defined here > > > > This happens because macro ATA_BASE_SHT(drv_name) defines .can_queue > > then then later in the initializer for ahci_sht, it gets redefined. > > > > Granted it probably works now, but sparse is correct to complain that > > this is bad usage. > > > > Hmm... That use is pretty much intentional to provide generic default > initial value and allow specific drivers to override if necessary and I > believe it's a valid C usage, no? IANAL as Viro -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
