I wrote:
Gwendal Grignou wrote:
+ count = 0;
+ SETUP_PORT_ATTRIBUTE(nr_pmp_links);
+ SETUP_PORT_ATTRIBUTE(idle_irq);
+ BUG_ON(count > ATA_PORT_ATTRS);
+ i->port_attrs[count] = NULL;
I understand that such preprocessor games are hard to avoid in code like
sysfs attribute setup. I have nothing better to suggest, but they are
ugly nevertheless, and may amount to bloat.
Anyway; the BUG_ON there should probably be a BUILD_BUG_ON.
...but alas gcc isn't clever enough: It won't report if ATA_PORT_ATTRS
was too small.
--
Stefan Richter
-=====-==--- =--- =--==
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
