On Tuesday 12 August 2008, Boris Petkov wrote: > >> Are we switching to SCSI opcodes? What about the generic packet commands in > >> <include/linux/cdrom.h>? > > > > I prefer to use them when possible but there is no strict policy. > > > > [ SCSI defines are shorter, one of the drivers was using them already > > and it also makes easier for comparing code with SCSI. ] > > I still think we should stick to one format or the other. All > the drivers' functions, for example, comply with a naming scheme > (ide_cd/ide_floppy/...) so opcodes shouldn't be an exception, imho... Some opcodes are only in <linux/cdrom.h> while the other ones only in <scsi/scsi.h> so it is not that simple without additional effort. I don't have a time for it at the moment (+ I consider it a low-prio task). However if you would like to look into it, please go ahead. Thanks, Bart -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html