On Thu, Aug 07, 2008 at 06:18:37AM +0200, Borislav Petkov wrote: > On Thu, Aug 07, 2008 at 01:03:58AM +0400, Alexander Inyukhin wrote: > > if (cdo->open == NULL || cdo->release == NULL) > > return -EINVAL; > > + if (cdo->audio_ioctl == NULL) > > + return -EINVAL; > > How about putting all checks above together: > if (!cdo->open || !cdo->release || !cdo->audio_ioctl) > return -EINVAL; > > ? I thought to place a warning message here and it is easier to blame separate check. Feel free to modify these lines. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
