Re: [patch] cdrom: Handle TOC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 07, 2008 at 08:11:45AM +0900, Tejun Heo wrote:
> Alexander Inyukhin wrote:
> > index d9d1b65..efc3aa0 100644
> > --- a/drivers/cdrom/cdrom.c
> > +++ b/drivers/cdrom/cdrom.c
> > @@ -394,6 +394,8 @@ int register_cdrom(struct cdrom_device_info *cdi)
> >  
> >  	if (cdo->open == NULL || cdo->release == NULL)
> >  		return -EINVAL;
> > +	if (cdo->audio_ioctl == NULL)
> > +		return -EINVAL;
> 
> Maybe sticking a BUG_ON() is a good idea just in case?

I'd do it only temporary so that we could catch drivers which do not set
cdo->audio_ioctl and then remove it after having fixed those. Otherwise it is a
bit too much, imho.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux