On Saturday 02 August 2008, Rafael J. Wysocki wrote: > On Saturday, 2 of August 2008, Bartlomiej Zolnierkiewicz wrote: > > * Keep pointer to ->init_chipset method also in > > struct ide_host and set it in ide_host_alloc_all(). > > > > * Add ide_pci_suspend() and ide_pci_resume() helpers > > (default ->suspend and ->resume implementations). > > > > * ->init_chipset can no longer be marked __devinit. > > > > * Add proper PCI PM support to IDE PCI host drivers > > (rz1000.c and tc86c001.c are skipped for now since > > they need to be converted from using ->init_hwif > > to use ->init_chipset instead). > > Well, first, the work on improving the PCI PM support by IDE drivers is much > appreciated. > > Still, since you're adding new routines etc., it may be a good time to > implement them using the new PM framework, as defined in > include/linux/pm.h (please also have a look at drivers/pci/pci-driver.c for the > PCI bus type's PM callbacks implementation details). Unfortunately, it's not > been well documented yet, so if you have any questions, please ask. > > In fact, we need some example implementations of the new PM callbacks and > since you know the drivers in question very well, we could use your > implementations as examples, if you don't mind. [Certainly, they would be > better than PM callbacks written by me for any driver. ;-) ] Thanks for reviewing the patch. I'll take a look into converting it to use new PM infrastructure (it may take a while so please be patient). -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
