> The code in question is 65 LOC total (43 LOC without counting comments) > so having a shared library just for it sounds like an overkill and we may People expect code in C files, so in headers it gets missed as well as dumped in a directory with no correlation between file name and subsystem. > just copy that one function from pata_legacy to ide_generic instead. If you are going to #include two copies you might as well just copy it. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html